Added styles type, which translates human-readable values to ANSI codes #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! In the future, it would be nice if you can add unit tests against your code though. Fine print: Personally I am sometimes too lazy to write tests, which is why I accepted your PR anyway. But it would be awesome to have tests. |
|
Happy to still write / adapt those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a translation table, so that we / users can specify human-readable color values and style settings (like "bold", "italic").
I've tried to keep it simple and not make the 'styles' struct keep a private array of style settings. That way, you can simply append to it and operate on it as you would with any other string slice. That in turn means, that we can't guarantee any values in that array being pre-translated before output. The styles.String() method compiles all set styles, translates them and returns a semicolon-concatenated string, which gets used by 'styled'.
There's an argument to be had, that pre-translating styles upon appending them would be faster if you re-use the 'styled' struct several times. I don't see this happening in code, though, so - as mentioned - I opted for simplicity.